Update x axis pseudolandmarks, remove obj input parameter
#1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove obj param
changes to reflect the move into homology sub package
move into homology
update homology init to include x-axis
HaleySchuhl
added
enhancement
…ub.com/danforthcenter/plantcv into update_x_axis_pseudolandmarks_iterable
refine import statement
add cv2 import
…ub.com/danforthcenter/plantcv into update_x_axis_pseudolandmarks_iterable
seeing if anything sticks, clear outputs and make a copy cuz someone on stack overflow had success
cast to np.array? ugh
Codecov Report
@@ Coverage Diff @@
## release-4.0 #1169 +/- ##
===============================================
Coverage 100.00% 100.00%
===============================================
Files 347 174 -173
Lines 15364 7730 -7634
===============================================
- Hits 15364 7730 -7634
Flags with carried forward coverage won't be shown. Click here to find out more.
|
HaleySchuhl
added
ready to review
and removed
work in progress
In the prior version there was an edge case where the mask could have data but the object could return 0 for moments. Since the objects are not derived directly from the mask I don't think that's possible
nfahlgren
approved these changes
Jun 15, 2023
46 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Type of update
Is this a:
Associated issues
#945
Additional context
Add any other context about the problem here.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md