Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analyze color function to analyze submodule #1170

Merged
merged 27 commits into from
May 24, 2023

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented May 19, 2023

Describe your changes
Moves the analyze_color function to pcv.analyze.color. Refactors the code to use the _iterate_analysis helper function. Supports labeled masks with automatic iteration over multiple input objects.

Also adds a built-in distribution plotting method to the Outputs class that is used by pcv.analyze.color and other analysis functions that plot histograms.

Type of update
Is this a: New feature or feature enhancement

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added enhancement Enhancements to existing features work in progress Mark work in progress labels May 19, 2023
@nfahlgren nfahlgren added this to the PlantCV v4.0 milestone May 19, 2023
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #1170 (fc8e740) into release-4.0 (e0d7c30) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1170   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              167       168    +1     
  Lines             7268      7351   +83     
=============================================
+ Hits              7268      7351   +83     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/analyze/__init__.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze/color.py 100.00% <100.00%> (ø)
plantcv/plantcv/classes.py 100.00% <100.00%> (ø)
plantcv/plantcv/plot_image.py 100.00% <100.00%> (ø)
plantcv/plantcv/print_image.py 100.00% <100.00%> (ø)

@nfahlgren nfahlgren marked this pull request as ready for review May 22, 2023 19:55
@nfahlgren nfahlgren added ready to review and removed work in progress Mark work in progress labels May 22, 2023
@nfahlgren nfahlgren merged commit b7a9453 into release-4.0 May 24, 2023
5 of 6 checks passed
PlantCV4 automation moved this from Pull Requests to Done May 24, 2023
@nfahlgren nfahlgren deleted the add-analyze-color branch May 24, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements to existing features ready to review
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants