Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define type for markers in watershed #1175

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Jun 6, 2023

Describe your changes
Scikit-image stopped converting the input markers to watershed to int32 by default and we do not explicitly define the data type of markers in pcv.segment_image_series or pcv.morphology.fill_segments. Tests started failing with scikit-image v0.21.

Type of update
Is this a: Bug fix

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

Scikit-image stopped converting the input markers to int32
@nfahlgren nfahlgren added the bugfix Bug fixes label Jun 6, 2023
@nfahlgren nfahlgren added this to the PlantCV v4.x milestone Jun 6, 2023
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #1175 (d39fe3b) into 4.x (250711e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               4.x     #1175   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          161       161           
  Lines         6890      6890           
=========================================
  Hits          6890      6890           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/morphology/fill_segments.py 100.00% <100.00%> (ø)
plantcv/plantcv/segment_image_series.py 100.00% <100.00%> (ø)

@nfahlgren nfahlgren merged commit 1e31628 into 4.x Jun 7, 2023
5 of 6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Jun 7, 2023
@nfahlgren nfahlgren deleted the fix-type-error-watershed branch June 7, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants