Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analyze.spectral_index function #1179

Merged
merged 6 commits into from
Jun 15, 2023
Merged

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Jun 12, 2023

Describe your changes
Adds the function spectral_index to the analyze subpackage. The function is a modified version of pcv.hyperspectral.analyze_index that utilizes the iterative analysis framework with labeled masks and produces an altair plot of recorded values.

Type of update
Is this a: New feature or feature enhancement

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added new feature New feature ideas and solutions work in progress Mark work in progress labels Jun 12, 2023
@nfahlgren nfahlgren added this to the PlantCV v4.0 milestone Jun 12, 2023
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #1179 (253436f) into release-4.0 (edd805f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1179   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              173       174    +1     
  Lines             7684      7727   +43     
=============================================
+ Hits              7684      7727   +43     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/analyze/__init__.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze/spectral_index.py 100.00% <100.00%> (ø)

@nfahlgren nfahlgren changed the title d analyze.spectral_index function Add analyze.spectral_index function Jun 12, 2023
@nfahlgren nfahlgren marked this pull request as ready for review June 13, 2023 20:59
@nfahlgren nfahlgren added ready to review and removed work in progress Mark work in progress labels Jun 13, 2023
@nfahlgren nfahlgren merged commit 4d5ab43 into release-4.0 Jun 15, 2023
5 of 6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Jun 15, 2023
@nfahlgren nfahlgren deleted the add-analyze-spectral-index branch June 15, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature ideas and solutions ready to review
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants