Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update y axis pseudolandmarks #1185

Merged
merged 19 commits into from
Jun 15, 2023
Merged

Update y axis pseudolandmarks #1185

merged 19 commits into from
Jun 15, 2023

Conversation

HaleySchuhl
Copy link
Contributor

Describe your changes
Move function into homology sub-package and remove the obj input parameter.

Type of update
Is this a:

  • New feature or feature enhancement
  • Work in progress

Associated issues
#945

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl self-assigned this Jun 13, 2023
@HaleySchuhl HaleySchuhl added enhancement Enhancements to existing features work in progress Mark work in progress labels Jun 13, 2023
@HaleySchuhl HaleySchuhl added this to Pull Requests in PlantCV4 via automation Jun 13, 2023
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.0 milestone Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #1185 (d4f266e) into release-4.0 (2efd7fd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1185   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              174       174           
  Lines             7730      7729    -1     
=============================================
- Hits              7730      7729    -1     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/__init__.py 100.00% <ø> (ø)
plantcv/plantcv/homology/__init__.py 100.00% <100.00%> (ø)
plantcv/plantcv/homology/y_axis_pseudolandmarks.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@HaleySchuhl HaleySchuhl added ready to review and removed work in progress Mark work in progress labels Jun 15, 2023
@nfahlgren nfahlgren merged commit 35710e2 into release-4.0 Jun 15, 2023
5 of 6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Jun 15, 2023
@nfahlgren nfahlgren deleted the update-y-axis-pseudo branch June 15, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements to existing features ready to review
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants