Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate analyze color #1190

Merged
merged 5 commits into from
Jun 20, 2023
Merged

Deprecate analyze color #1190

merged 5 commits into from
Jun 20, 2023

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Jun 13, 2023

Describe your changes
Deprecates pcv.analyze_color. See pcv.analyze.color as an alternative.

Type of update
Is this a: deprecation

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added work in progress Mark work in progress update Updates an existing feature/method labels Jun 13, 2023
@nfahlgren nfahlgren added this to the PlantCV v4.0 milestone Jun 13, 2023
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #1190 (c1bff8f) into release-4.0 (998d2fd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1190   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              168       167    -1     
  Lines             7276      7200   -76     
=============================================
- Hits              7276      7200   -76     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/__init__.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@HaleySchuhl HaleySchuhl marked this pull request as ready for review June 20, 2023 23:14
@nfahlgren nfahlgren merged commit da4a761 into release-4.0 Jun 20, 2023
5 of 6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Jun 20, 2023
@nfahlgren nfahlgren deleted the deprecate-analyze-color branch June 20, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update Updates an existing feature/method work in progress Mark work in progress
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants