Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate cluster contours splitimg #1196

Merged
merged 7 commits into from
Jun 17, 2023

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Jun 15, 2023

Describe your changes
A clear and concise description of what changes are made by this pull request.
What was the previous functionality (if relevant) and what can we do now with
these changes.

Type of update
Is this a:

  • Bug fix
  • New feature or feature enhancement
  • Update to documentation
  • Work in progress

Associated issues
Reference associated issue numbers. Does this pull request close any issues?

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #1196 (e1ef709) into release-4.0 (a86abb3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1196   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              173       172    -1     
  Lines             7615      7530   -85     
=============================================
- Hits              7615      7530   -85     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/__init__.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@HaleySchuhl HaleySchuhl self-assigned this Jun 16, 2023
@HaleySchuhl HaleySchuhl added ready to review cleanup Code quality updates labels Jun 16, 2023
@nfahlgren nfahlgren merged commit e4c25b8 into release-4.0 Jun 17, 2023
5 of 6 checks passed
@nfahlgren nfahlgren deleted the deprecate-cluster_contours_splitimg branch June 17, 2023 15:33
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Jul 2, 2023
@nfahlgren nfahlgren added this to the PlantCV v4.0 milestone Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality updates ready to review
Projects
PlantCV4
  
Pull Requests
Development

Successfully merging this pull request may close these issues.

None yet

2 participants