Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move landmark_reference_pt_dist to the homology submodule #1199

Merged
merged 5 commits into from
Jun 16, 2023

Conversation

nfahlgren
Copy link
Member

Describe your changes
Relocate the pcv.landmark_reference_pt_dist function to pcv.homology.landmark_reference_pt_dist.

Type of update
Is this a: update

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added ready to review update Updates an existing feature/method labels Jun 16, 2023
@nfahlgren nfahlgren added this to the PlantCV v4.0 milestone Jun 16, 2023
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #1199 (0bbc91b) into release-4.0 (8a6ae12) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1199   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              174       174           
  Lines             7694      7694           
=============================================
  Hits              7694      7694           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/__init__.py 100.00% <ø> (ø)
...tcv/plantcv/homology/landmark_reference_pt_dist.py 100.00% <ø> (ø)
plantcv/plantcv/homology/__init__.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@nfahlgren nfahlgren merged commit 53fc9bf into release-4.0 Jun 16, 2023
5 of 6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Jun 16, 2023
@nfahlgren nfahlgren deleted the move-landmark-fx branch June 16, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review update Updates an existing feature/method
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants