Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_color_card typo fix, move "label" param into correct function #1202

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

HaleySchuhl
Copy link
Contributor

Describe your changes
Update doc page so that the label parameter is included while calling find_color_card rather than create_color_card_mask.

Type of update
Is this a:

  • typo fix

Associated issues

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl changed the title find_cmove "label" param into correct function find_color_card typo fix, move "label" param into correct function Jun 21, 2023
@HaleySchuhl HaleySchuhl mentioned this pull request Jun 21, 2023
8 tasks
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #1202 (af30be1) into main (58777cb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1202   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          141       141           
  Lines         6024      6024           
=========================================
  Hits          6024      6024           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@nfahlgren nfahlgren merged commit e5cc9a9 into main Jun 21, 2023
6 checks passed
@nfahlgren nfahlgren deleted the find_color_card.md-typo-fix branch June 21, 2023 19:44
@nfahlgren nfahlgren added the documentation Documentation issues or features label Jul 2, 2023
@nfahlgren nfahlgren added this to In progress in PlantCV3 via automation Jul 2, 2023
@nfahlgren nfahlgren added this to the PlantCV v3.15 milestone Jul 2, 2023
@nfahlgren nfahlgren moved this from In progress to Done in PlantCV3 Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation issues or features
Projects
No open projects
PlantCV3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants