Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate analyze_object #1206

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Deprecate analyze_object #1206

merged 2 commits into from
Jun 23, 2023

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Jun 22, 2023

Describe your changes
In PlantCV4 pcv.analyze_object is replaced by pcv.analyze.size

Type of update
Is this a: update

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added ready to review update Updates an existing feature/method labels Jun 22, 2023
@nfahlgren nfahlgren added this to the PlantCV v4.0 milestone Jun 22, 2023
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #1206 (bbe190b) into release-4.0 (2409888) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           release-4.0     #1206    +/-   ##
==============================================
  Coverage       100.00%   100.00%            
==============================================
  Files              166       165     -1     
  Lines             7163      7045   -118     
==============================================
- Hits              7163      7045   -118     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/__init__.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@nfahlgren nfahlgren merged commit e81873c into release-4.0 Jun 23, 2023
5 of 6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Jun 23, 2023
@nfahlgren nfahlgren deleted the deprecate-analyze-object branch June 23, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review update Updates an existing feature/method
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants