Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate object composition #1216

Merged
merged 6 commits into from
Jul 11, 2023
Merged

Conversation

nfahlgren
Copy link
Member

Describe your changes
Deprecates the pcv.object_composition function. Refactors pct.report_size_marker to utilize the helper function _object_composition instead of the public function.

Type of update
Is this a: update

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

Replace with _object_composition helper function
@nfahlgren nfahlgren added work in progress Mark work in progress update Updates an existing feature/method labels Jul 5, 2023
@nfahlgren nfahlgren added this to the PlantCV v4.0 milestone Jul 5, 2023
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #1216 (27d71f1) into release-4.0 (c103c33) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1216   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              162       161    -1     
  Lines             6987      6957   -30     
=============================================
- Hits              6987      6957   -30     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/__init__.py 100.00% <ø> (ø)
plantcv/plantcv/report_size_marker_area.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@nfahlgren nfahlgren merged commit 17d8c37 into release-4.0 Jul 11, 2023
5 of 6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Jul 11, 2023
@nfahlgren nfahlgren deleted the deprecate-object-composition branch July 11, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review update Updates an existing feature/method
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants