remove max_val param from threshold.texture() #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afinit
commented
Jul 6, 2023
| @@ -1057,12 +1057,13 @@ pages for more details on the input and output variable types. | |||
| #### plantcv.threshold.saturation | |||
|
|
|||
| * pre v3.8: NA | |||
| * post v3.8: bin_img = **plantcv.threshold.saturation**(*rgb_img, threshold=255, channel="any") | |||
| * post v3.8: bin_img = **plantcv.threshold.saturation**(*rgb_img, threshold=255, channel="any"*) | |||
There was a problem hiding this comment.
noticed this missing *
afinit
commented
Jul 6, 2023
|
|
||
| #### plantcv.threshold.texture_filter | ||
| #### plantcv.threshold.texture |
There was a problem hiding this comment.
the texture function name was mismatched here. I took a look at the git history and it looks like it's always been mismatched, so i changed it here. happy to adjust if needed
12 tasks
This was referenced Jul 6, 2023
Codecov Report
@@ Coverage Diff @@
## release-4.0 #1219 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 163 163
Lines 6994 6994
=============================================
Hits 6994 6994
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nfahlgren
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Builds on: #1218
Describe your changes
Type of update
feature enhancement
Associated issues
completes one task from this ticket: #1194
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md