Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove max_val param from threshold.dual_channels() #1224

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

afinit
Copy link
Collaborator

@afinit afinit commented Jul 7, 2023

Describe your changes

  • Removes max_val param from the threshold.dual_channels method
  • updates function documentation
  • updates updating.md
  • fixes tests broken by change

Type of update
feature enhancement

Associated issues
completes one task from this ticket: #1194

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@afinit afinit added this to the PlantCV v4.0 milestone Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #1224 (8098cd2) into release-4.0 (91f2490) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1224   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              162       162           
  Lines             6987      6987           
=============================================
  Hits              6987      6987           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/threshold/threshold_methods.py 100.00% <100.00%> (ø)

@nfahlgren nfahlgren merged commit c103c33 into release-4.0 Jul 7, 2023
5 of 6 checks passed
@nfahlgren nfahlgren deleted the release-4.0-dual_channels-max-val branch July 7, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants