Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate visualize cluster contours #1229

Merged
merged 8 commits into from
Jul 14, 2023

Conversation

HaleySchuhl
Copy link
Contributor

Describe your changes

Type of update
Is this a:

  • Update

Associated issues
Reference associated issue numbers. Does this pull request close any issues?

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #1229 (2a4793c) into release-4.0 (d060dff) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1229   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              161       160    -1     
  Lines             6954      6919   -35     
=============================================
- Hits              6954      6919   -35     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/visualize/__init__.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@HaleySchuhl HaleySchuhl added this to Pull Requests in PlantCV4 via automation Jul 13, 2023
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.0 milestone Jul 13, 2023
@HaleySchuhl HaleySchuhl self-assigned this Jul 13, 2023
@HaleySchuhl HaleySchuhl changed the base branch from main to release-4.0 July 13, 2023 20:28
@nfahlgren nfahlgren merged commit 92556d6 into release-4.0 Jul 14, 2023
5 of 6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Jul 14, 2023
@nfahlgren nfahlgren deleted the deprecate-visualize_cluster_contours branch July 14, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants