-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PSII dataset names #1309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfahlgren
added
Epic
Discussions and broad multi-issue ideas
update
Updates an existing feature/method
labels
Jul 25, 2023
Codecov Report
@@ Coverage Diff @@
## release-4.0 #1309 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 157 157
Lines 6757 6759 +2
=============================================
+ Hits 6757 6759 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nfahlgren
added
ready to review
and removed
Epic
Discussions and broad multi-issue ideas
labels
Jul 25, 2023
I'm not sure I've got data to test on for OJIP.. I don't think the sample data I have for Katie is good to test this. could you please point me to a test image? @nfahlgren |
HaleySchuhl
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Renames
PSII_data
dataset attributes fromdarkadapted
andlightadapted
toojip_dark
andojip_light
, based on the name of the method, OJIP. This will allow future addition of PAM measurements.Type of update
Is this a: update
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md