Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PSII dataset names #1309

Merged
merged 9 commits into from
Jul 25, 2023
Merged

Update PSII dataset names #1309

merged 9 commits into from
Jul 25, 2023

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Jul 25, 2023

Describe your changes
Renames PSII_data dataset attributes from darkadapted and lightadapted to ojip_dark and ojip_light, based on the name of the method, OJIP. This will allow future addition of PAM measurements.

Type of update
Is this a: update

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added Epic Discussions and broad multi-issue ideas update Updates an existing feature/method labels Jul 25, 2023
@nfahlgren nfahlgren added this to the PlantCV v4.0 milestone Jul 25, 2023
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #1309 (3636334) into release-4.0 (6f2f7d4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1309   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              157       157           
  Lines             6757      6759    +2     
=============================================
+ Hits              6757      6759    +2     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
plantcv/plantcv/analyze/npq.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze/yii.py 100.00% <100.00%> (ø)
plantcv/plantcv/classes.py 100.00% <100.00%> (ø)
...lantcv/plantcv/photosynthesis/read_cropreporter.py 100.00% <100.00%> (ø)
...cv/plantcv/photosynthesis/reassign_frame_labels.py 100.00% <100.00%> (ø)
...ntcv/plantcv/visualize/chlorophyll_fluorescence.py 100.00% <100.00%> (ø)

@nfahlgren nfahlgren added ready to review and removed Epic Discussions and broad multi-issue ideas labels Jul 25, 2023
@HaleySchuhl
Copy link
Contributor

I'm not sure I've got data to test on for OJIP.. I don't think the sample data I have for Katie is good to test this. could you please point me to a test image? @nfahlgren

@nfahlgren nfahlgren merged commit 5cc1a25 into release-4.0 Jul 25, 2023
5 of 6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Jul 25, 2023
@nfahlgren nfahlgren deleted the update-psii-datasets branch July 25, 2023 17:06
@nfahlgren nfahlgren mentioned this pull request Jul 26, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review update Updates an existing feature/method
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants