Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove max value references #1314

Merged
merged 5 commits into from
Jul 27, 2023
Merged

Conversation

HaleySchuhl
Copy link
Contributor

Describe your changes
Remove references to the deprecated max_value parameter throughout doc pages.

Type of update
Is this a:

  • Update to documentation

Associated issues
#1304

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added documentation Documentation issues or features update Updates an existing feature/method labels Jul 26, 2023
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.0 milestone Jul 26, 2023
@HaleySchuhl HaleySchuhl self-assigned this Jul 26, 2023
@HaleySchuhl HaleySchuhl added this to Pull Requests in PlantCV4 via automation Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #1314 (381cf6f) into release-4.0 (70a3c24) will not change coverage.
Report is 1 commits behind head on release-4.0.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1314   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              157       157           
  Lines             6759      6758    -1     
=============================================
- Hits              6759      6758    -1     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@nfahlgren nfahlgren merged commit b84c654 into release-4.0 Jul 27, 2023
1 check passed
PlantCV4 automation moved this from Pull Requests to Done Jul 27, 2023
@nfahlgren nfahlgren deleted the remove-max_value-references branch July 27, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation issues or features ready to review update Updates an existing feature/method
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants