Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hyperspectral crop #1323

Merged
merged 8 commits into from
Aug 10, 2023
Merged

Add hyperspectral crop #1323

merged 8 commits into from
Aug 10, 2023

Conversation

maliagehan
Copy link
Member

@maliagehan maliagehan commented Aug 7, 2023

Describe your changes
Updates crop function to return a hyperspectral image object if that is what is inputted for cropping. Function will still work on an array with x dimensions (not removing old method) because that could still be useful.

Type of update
Is this a:

  • Bug fix
  • New feature or feature enhancement

Associated issues
#1312

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

maliagehan and others added 3 commits August 3, 2023 21:22
update crop function so it can crop and return a hyperspectral datacube
updated crop function and tests so that hyperspectral data is returned if it is inputted to crop. The documentation already says it's possible to crop hyperspectral so i didn't change that.
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #1323 (e63c24e) into release-4.0 (51e36aa) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1323   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              157       157           
  Lines             6750      6757    +7     
=============================================
+ Hits              6750      6757    +7     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
plantcv/plantcv/crop.py 100.00% <100.00%> (ø)

@nfahlgren nfahlgren added new feature New feature ideas and solutions ready to review labels Aug 10, 2023
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Aug 10, 2023
@nfahlgren nfahlgren added this to the PlantCV v4.0 milestone Aug 10, 2023
@nfahlgren nfahlgren merged commit 18e4b6d into release-4.0 Aug 10, 2023
5 of 6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Aug 10, 2023
@nfahlgren nfahlgren deleted the add-hyperspectral-crop branch August 10, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature ideas and solutions ready to review
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants