Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to ksize in adaptive thresholding methods #1325

Merged
merged 8 commits into from
Aug 10, 2023

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Aug 10, 2023

Describe your changes
For consistency, call the parameter ksize instead of block_size since we use ksize for kernel size elsewhere.

Type of update
Is this a:

  • Update

Associated issues
#1304

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

block_size to ksize
block_size to ksize
update block_size to ksize in mean and gaussian threshold
@HaleySchuhl HaleySchuhl added ready to review update Updates an existing feature/method labels Aug 10, 2023
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.0 milestone Aug 10, 2023
@HaleySchuhl HaleySchuhl self-assigned this Aug 10, 2023
@HaleySchuhl HaleySchuhl added this to Pull Requests in PlantCV4 via automation Aug 10, 2023
@HaleySchuhl HaleySchuhl changed the base branch from main to release-4.0 August 10, 2023 18:52
@HaleySchuhl HaleySchuhl mentioned this pull request Aug 10, 2023
12 tasks
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #1325 (7ce560a) into release-4.0 (74de53b) will not change coverage.
Report is 1 commits behind head on release-4.0.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1325   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              157       157           
  Lines             6757      6757           
=============================================
  Hits              6757      6757           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
plantcv/plantcv/threshold/threshold_methods.py 100.00% <100.00%> (ø)

@nfahlgren nfahlgren merged commit 95dffb5 into release-4.0 Aug 10, 2023
5 of 6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Aug 10, 2023
@nfahlgren nfahlgren deleted the rename_to_ksize branch August 10, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review update Updates an existing feature/method
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants