Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove binder buttons from tutorial gallery #1331

Merged
merged 6 commits into from
Aug 14, 2023

Conversation

HaleySchuhl
Copy link
Contributor

Describe your changes
Binder is unreliable so we want to prompt people to go to the static page docs primarily. Also, having the buttton in two places makes it easier to have an error while keeping these updated.

Type of update
Is this a:

  • Bug fix
  • New feature or feature enhancement
  • Update to documentation

Associated issues
Reference associated issue numbers. Does this pull request close any issues?

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl changed the base branch from main to release-4.0 August 11, 2023 16:21
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #1331 (37821dc) into release-4.0 (6d461dd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1331   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              156       156           
  Lines             6829      6829           
=============================================
  Hits              6829      6829           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@nfahlgren
Copy link
Member

Is this ready to review? If so, please apply labels

@HaleySchuhl HaleySchuhl added documentation Documentation issues or features ready to review labels Aug 14, 2023
@nfahlgren nfahlgren merged commit 8d9d7c3 into release-4.0 Aug 14, 2023
5 of 6 checks passed
@nfahlgren nfahlgren deleted the remove-binder-buttons-tutorial-gallery branch August 14, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation issues or features ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants