Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change license mpl2 #1334

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Change license mpl2 #1334

merged 2 commits into from
Aug 16, 2023

Conversation

nfahlgren
Copy link
Member

Describe your changes
Starting with v4, replaces the MIT license with a Mozilla Public License Version 2.0. The reasons are summarized by Janis Lesinskis here: https://www.lesinskis.com/MIT-licence-community-hostile.html. Our main purpose here is to avoid the patent issues the post brings up. We also want to continue encourage commercial use and reuse/remixing of PlantCV, which is still allowable under MPLv2. But MPLv2 encourages contribution back to the original open source, while allowing for closed source additions on top.

Type of update
Is this a: update

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added ready to review update Updates an existing feature/method labels Aug 15, 2023
@nfahlgren nfahlgren added this to the PlantCV v4.0 milestone Aug 15, 2023
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Aug 15, 2023
@nfahlgren nfahlgren changed the title Change license mpl2 [skip ci] Change license mpl2 Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1334 (304fcd2) into release-4.0 (8d9d7c3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1334   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              156       156           
  Lines             6829      6829           
=============================================
  Hits              6829      6829           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@nfahlgren nfahlgren mentioned this pull request Aug 16, 2023
12 tasks
@nfahlgren nfahlgren merged commit f296737 into release-4.0 Aug 16, 2023
5 of 6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Aug 16, 2023
@nfahlgren nfahlgren deleted the change-license-mpl2 branch August 16, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review update Updates an existing feature/method
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants