Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set num_labels to num ROIs #1340

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Set num_labels to num ROIs #1340

merged 1 commit into from
Aug 18, 2023

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Aug 18, 2023

Describe your changes
pcv.create_labels was incorrectly setting the number of labels to the number of unique labels in the labeled mask. When plants are missing and ROIs are supplied, this can under count the number of labels. Instead we changed the number of labels to the number of input ROIs, when relevant.

Type of update
Is this a: Bug fix

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added the bugfix Bug fixes label Aug 18, 2023
@nfahlgren nfahlgren added this to the PlantCV v4.0 milestone Aug 18, 2023
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #1340 (56d6cc8) into release-4.0 (643c68b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1340   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              156       156           
  Lines             6857      6857           
=============================================
  Hits              6857      6857           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
plantcv/plantcv/create_labels.py 100.00% <100.00%> (ø)

@nfahlgren nfahlgren merged commit 940eefc into release-4.0 Aug 18, 2023
5 of 6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Aug 18, 2023
@nfahlgren nfahlgren deleted the fix-num-labels branch August 18, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fixes
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants