Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove find objects functions #1341

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Remove find objects functions #1341

merged 1 commit into from
Aug 18, 2023

Conversation

dhiraj-ms
Copy link
Contributor

Describe your changes
Find objects function is no longer being used in version 4.0.

Type of update
This is an update

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@dhiraj-ms dhiraj-ms added ready to review update Updates an existing feature/method labels Aug 18, 2023
@dhiraj-ms dhiraj-ms added this to the PlantCV v4.0 milestone Aug 18, 2023
@dhiraj-ms dhiraj-ms added this to Pull Requests in PlantCV4 via automation Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #1341 (53b8477) into release-4.0 (940eefc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1341   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              156       155    -1     
  Lines             6857      6839   -18     
=============================================
- Hits              6857      6839   -18     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
plantcv/plantcv/__init__.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@nfahlgren nfahlgren merged commit 600e622 into release-4.0 Aug 18, 2023
5 of 6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Aug 18, 2023
@nfahlgren nfahlgren deleted the remove-object branch August 18, 2023 22:08
@nfahlgren
Copy link
Member

@all-contributors please add @dhiraj-ms for code, doc, test

@allcontributors
Copy link
Contributor

@nfahlgren

I've put up a pull request to add @dhiraj-ms! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review update Updates an existing feature/method
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants