Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update matplotlib supported versions #1353

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

nfahlgren
Copy link
Member

Describe your changes
Removes upper limit on matplotlib versions and fixes one issue in Points related to changes to the matplotlib API. The change is backwards compatible with older versions of matplotlib.

Type of update
Is this a: update

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added ready to review update Updates an existing feature/method labels Aug 25, 2023
@nfahlgren nfahlgren added this to the PlantCV v4.0.1 milestone Aug 25, 2023
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #1353 (c4a8ab8) into main (ebd9b96) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1353   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          155       155           
  Lines         6841      6840    -1     
=========================================
- Hits          6841      6840    -1     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
plantcv/plantcv/classes.py 100.00% <100.00%> (ø)

@nfahlgren nfahlgren merged commit e1e3a46 into main Aug 25, 2023
6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Aug 25, 2023
@nfahlgren nfahlgren deleted the update-matplotlib-supported-versions branch August 25, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review update Updates an existing feature/method
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants