Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper limit restriction on pandas #1354

Closed
wants to merge 1 commit into from

Conversation

nfahlgren
Copy link
Member

Describe your changes
Removes limit on the maximum version of pandas supported. Fixes issue with tests for constella that used a deprecated pandas DataFrame method.

Type of update
Is this a: update

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added ready to review update Updates an existing feature/method labels Aug 25, 2023
@nfahlgren nfahlgren added this to the PlantCV v4.0.1 milestone Aug 25, 2023
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #1354 (c446d43) into main (e1e3a46) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1354   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          155       155           
  Lines         6840      6840           
=========================================
  Hits          6840      6840           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@nfahlgren
Copy link
Member Author

These changes were accidentally pushed to main, so closing.

@nfahlgren nfahlgren closed this Aug 25, 2023
PlantCV4 automation moved this from Pull Requests to Done Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review update Updates an existing feature/method
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant