Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multi label input #1361

Merged
merged 11 commits into from
Oct 2, 2023
Merged

Enable multi label input #1361

merged 11 commits into from
Oct 2, 2023

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Oct 2, 2023

Describe your changes
Modifies the helper function _iterate_analysis to accept either a string label or a list of labels equal to the length of n_labels. If a string is input, a list of length n_labels is made by repeating the input string. The iterator uses the list of labels to label each object label. If the length of labels is not equal to n_labels a fatal error is triggered.

We might need to update all analysis doc pages to indicate that a list of labels can be input.

Type of update
Is this a:

  • New feature or feature enhancement

Associated issues
#1360

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added the enhancement Enhancements to existing features label Oct 2, 2023
@nfahlgren nfahlgren added this to the PlantCV v4.1 milestone Oct 2, 2023
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #1361 (6d6e701) into main (5fe40c7) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1361   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          155       155           
  Lines         6840      6861   +21     
=========================================
+ Hits          6840      6861   +21     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
plantcv/plantcv/_helpers.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze/npq.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze/yii.py 100.00% <100.00%> (ø)

Copy link
Member

@maliagehan maliagehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked in a multiplant workflow and checked output.

@maliagehan maliagehan merged commit 2d19c5a into main Oct 2, 2023
6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Oct 2, 2023
@maliagehan maliagehan deleted the enable-multi-label-input branch October 2, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements to existing features
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants