Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation minor bug fixes #1372

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Documentation minor bug fixes #1372

merged 4 commits into from
Oct 13, 2023

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Oct 12, 2023

Describe your changes
Two doc bug fixes. Typo in pcv.roi2mask doc page and fix the parameter name in updating.md for pcv.flood_fill which has the plural points parameter now.

Type of update
Is this a:

  • Bug fix
  • Update to documentation

Associated issues

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

example use typo fix
flood_fill param plural "points"
@HaleySchuhl HaleySchuhl added documentation Documentation issues or features bugfix Bug fixes labels Oct 12, 2023
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.1 milestone Oct 12, 2023
@HaleySchuhl HaleySchuhl self-assigned this Oct 12, 2023
@HaleySchuhl HaleySchuhl added this to Pull Requests in PlantCV4 via automation Oct 12, 2023
update docstring
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #1372 (402a14a) into main (d8ae17f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1372   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          156       156           
  Lines         6878      6878           
=========================================
  Hits          6878      6878           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
plantcv/plantcv/floodfill.py 100.00% <ø> (ø)

found an extra comma
@nfahlgren nfahlgren merged commit 21ab67f into main Oct 13, 2023
6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Oct 13, 2023
@nfahlgren nfahlgren deleted the mid-October-bugfixes branch October 13, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fixes documentation Documentation issues or features ready to review
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

roi2mask documentation needs updating
2 participants