Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spectral wavelengths for CropReporter datasets #1374

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Oct 13, 2023

Describe your changes
Updates the wavelengths assigned to spectral frames in CropReporter datasets to:

  • 640, 550, 475nm are Red, Green, Blue
  • 540, 710, 770nm are Anthocyanin, red-Edge, NIR

The existing wavelengths could cause some spectral indices to be computed with the incorrect frame: see #1373.

Type of update
Is this a: Bug fix

Associated issues
Closes #1373

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added this to the PlantCV v4.1 milestone Oct 13, 2023
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #1374 (3c47fd3) into main (21ab67f) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1374   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          156       156           
  Lines         6878      6878           
=========================================
  Hits          6878      6878           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lantcv/plantcv/photosynthesis/read_cropreporter.py 100.00% <100.00%> (ø)

@nfahlgren nfahlgren merged commit 10a33cc into main Oct 19, 2023
6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Oct 19, 2023
@nfahlgren nfahlgren deleted the update-cropreporter-wavelengths branch October 19, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

Cropreporter imaging wavelengths
2 participants