Add metadata method #1375
Merged
Add metadata method #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add function structure based on add_observation
add metadata attribute
HaleySchuhl
added
new feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1375 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 158 158
Lines 6925 6944 +19
=========================================
+ Hits 6925 6944 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fix header
add metadata to other instances of CSV writing & typo metat fix
values is plural
change syntax so we have a list of strings and not a dictionary
combine lists to make header differently ?
combine lists with +
only add to list, not in zip
deepsource issues
add test
specific unit test?
misunderstood what i was slicing
counting
update method name
HaleySchuhl
added
ready to review
and removed
work in progress
Previously it generated a list of all metadata term properties
nfahlgren
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add method
add_metadatato theOutputsclass. Allow storage of metadata that is known for the dataset, but is not part of the filename.Type of update
Is this a:
Associated issues
closes #1368
closes #490
Additional context
Hopefully compliant with plantcv-run-workflow and json output, but also integrate with
outformat="csv"for the plantcv users doing medium throughput analysis in jupyter notebooks.For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md