Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update colorspaces.py add CMYK #1390

Merged
merged 10 commits into from
Nov 14, 2023
Merged

Update colorspaces.py add CMYK #1390

merged 10 commits into from
Nov 14, 2023

Conversation

HaleySchuhl
Copy link
Contributor

add logic for additional colorspaces in visualization plot

Describe your changes
A clear and concise description of what changes are made by this pull request.
What was the previous functionality (if relevant) and what can we do now with
these changes.

Type of update
Is this a:

  • feature enhancement
  • Work in progress

Associated issues
Reference associated issue numbers. Does this pull request close any issues?

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

add logic for additional colorspaces in plot
@HaleySchuhl HaleySchuhl added enhancement Enhancements to existing features work in progress Mark work in progress update Updates an existing feature/method labels Nov 13, 2023
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.1 milestone Nov 13, 2023
@HaleySchuhl HaleySchuhl added this to Pull Requests in PlantCV4 via automation Nov 13, 2023
@HaleySchuhl HaleySchuhl self-assigned this Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #1390 (167bd0f) into main (1d5efc8) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1390   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          158       158           
  Lines         6934      6940    +6     
=========================================
+ Hits          6934      6940    +6     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
plantcv/plantcv/rgb2gray_cmyk.py 100.00% <100.00%> (ø)
plantcv/plantcv/visualize/colorspaces.py 100.00% <100.00%> (ø)

@HaleySchuhl HaleySchuhl added ready to review and removed work in progress Mark work in progress labels Nov 13, 2023
@nfahlgren nfahlgren merged commit c0d7961 into main Nov 14, 2023
6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Nov 14, 2023
@nfahlgren nfahlgren deleted the add-cymk-vis_colorspaces branch November 14, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements to existing features ready to review update Updates an existing feature/method
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants