Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLK-D200 #1393

Merged
merged 5 commits into from
Nov 13, 2023
Merged

FLK-D200 #1393

merged 5 commits into from
Nov 13, 2023

Conversation

kmurphy61
Copy link
Contributor

Describe your changes
DeepSource FLK-D200, update PlantCV code to fit DeepSource suggestion of """ on the same line as the associated code and remove extra white space within """.

Type of update
Is this a:

  • DeepSource fix

Associated issues
Issue #1382

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

Remove space, move """ to one line, DeepSource FLK-D200
Move """ to one line in cli.py for DeepSource FLK-D200
Move """ to one line, remove space for cli.py DeepSource FLK-D200
Move """ to one line, remove space in cli.py, DeepSource issue FLK-D200
@kmurphy61 kmurphy61 added the cleanup Code quality updates label Nov 13, 2023
@kmurphy61 kmurphy61 added this to the PlantCV v4.1 milestone Nov 13, 2023
@kmurphy61 kmurphy61 self-assigned this Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #1393 (4ec05ef) into main (66708e7) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1393   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          158       158           
  Lines         6939      6939           
=========================================
  Hits          6939      6939           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
plantcv/learn/cli.py 100.00% <ø> (ø)
plantcv/utils/cli.py 100.00% <ø> (ø)

@nfahlgren nfahlgren merged commit 8952f08 into main Nov 13, 2023
6 checks passed
@nfahlgren nfahlgren deleted the FLK-D200 branch November 13, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants