Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed comparison order per deepsource standards #1394

Merged
merged 3 commits into from
Nov 14, 2023
Merged

changed comparison order per deepsource standards #1394

merged 3 commits into from
Nov 14, 2023

Conversation

joshqsumner
Copy link
Contributor

Describe your changes
Changed comparison order in an if statement to align with deepsource's best practices.

Type of update
Is this a stylistic edit via deepsource.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #1394 (d780df0) into main (11da74a) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1394   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          158       158           
  Lines         6937      6937           
=========================================
  Hits          6937      6937           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
plantcv/plantcv/homology/acute.py 100.00% <100.00%> (ø)

@nfahlgren nfahlgren added ready to review cleanup Code quality updates labels Nov 14, 2023
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Nov 14, 2023
@nfahlgren nfahlgren added this to the PlantCV v4.1 milestone Nov 14, 2023
@nfahlgren nfahlgren merged commit 6f086b7 into main Nov 14, 2023
6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Nov 14, 2023
@nfahlgren nfahlgren deleted the pyl-c2201 branch November 14, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality updates ready to review
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants