Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYL-W0612 deepsource replace unused vars #1395

Merged
merged 61 commits into from
Nov 15, 2023
Merged

PYL-W0612 deepsource replace unused vars #1395

merged 61 commits into from
Nov 15, 2023

Conversation

HaleySchuhl
Copy link
Contributor

Describe your changes
Resolving issue PYL-W0612 REPLACE UNUSED VARS

Type of update
Is this a:

  • Bug fix
  • New feature or feature enhancement
  • Update to documentation
  • Work in progress

Associated issues
#1382

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added the cleanup Code quality updates label Nov 13, 2023
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.1 milestone Nov 13, 2023
@HaleySchuhl HaleySchuhl added this to Pull Requests in PlantCV4 via automation Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #1395 (5518c43) into main (c0d7961) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1395   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          158       158           
  Lines         6940      6925   -15     
=========================================
- Hits          6940      6925   -15     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
plantcv/learn/naive_bayes.py 100.00% <100.00%> (ø)
plantcv/parallel/__init__.py 100.00% <100.00%> (ø)
plantcv/parallel/job_builder.py 100.00% <100.00%> (ø)
plantcv/parallel/parsers.py 100.00% <100.00%> (ø)
plantcv/parallel/process_results.py 100.00% <100.00%> (ø)
plantcv/plantcv/_helpers.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze/bound_horizontal.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze/bound_vertical.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze/grayscale.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze/size.py 100.00% <100.00%> (ø)
... and 17 more

more unused variables
multiple unused vars as one underscore ?
it complained about not enough to unpack
Unused variable 'i'
Unused variable 'masks'
unused var 238 & 239
Unused variable 'cnt'
Unused variable 'ix'
Unused variable 'dirs'
Unused variable 'w'
Unused variable 'wkept_hierarchy
Unused variable 'hist_fig'
Unused variable 'ret1'
ret, cpoint_h, and ret2 unused vars
Unused variable 'fig_hist'
Unused variable 'right_hierarchy'
Unused variable 'height'
unused var
@HaleySchuhl HaleySchuhl self-assigned this Nov 13, 2023
@HaleySchuhl
Copy link
Contributor Author

Might have one more deepsource complaint

@nfahlgren nfahlgren merged commit 48a60d1 into main Nov 15, 2023
5 of 6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Nov 15, 2023
@nfahlgren nfahlgren deleted the PYL-W0612 branch November 15, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality updates ready to review
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants