-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PYL-W0612 deepsource replace unused vars #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1395 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 158 158
Lines 6940 6925 -15
=========================================
- Hits 6940 6925 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
more unused variables
multiple unused vars as one underscore ?
it complained about not enough to unpack
Unused variable 'i'
Unused variable 'masks'
unused var 238 & 239
Unused variable 'cnt'
Unused variable 'ix'
Unused variable 'dirs'
Unused variable 'w'
Unused variable 'wkept_hierarchy
Unused variable 'hist_fig'
Unused variable 'ret1'
ret, cpoint_h, and ret2 unused vars
Unused variable 'fig_hist'
Unused variable 'right_hierarchy'
Unused variable 'height'
unused var
unused var
unused var
unused var
docstring whitespace
indentation
…into PYL-W0612
Might have one more deepsource complaint |
unused var t_cc snuck back in
nfahlgren
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Resolving issue PYL-W0612 REPLACE UNUSED VARS
Type of update
Is this a:
Associated issues
#1382
Additional context
Add any other context about the problem here.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md