Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted variable mask=mask #1404

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Deleted variable mask=mask #1404

merged 3 commits into from
Nov 14, 2023

Conversation

zeeuqsze
Copy link
Contributor

Describe your changes
Removed variable that references itself

Type of update
Is this a:

  • Update to documentation

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@zeeuqsze zeeuqsze added the cleanup Code quality updates label Nov 13, 2023
@zeeuqsze zeeuqsze added this to Pull Requests in PlantCV4 via automation Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #1404 (82a2942) into main (36e1fe1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1404   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          158       158           
  Lines         6939      6937    -2     
=========================================
- Hits          6939      6937    -2     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
plantcv/plantcv/threshold/threshold_methods.py 100.00% <ø> (ø)

@nfahlgren nfahlgren merged commit 93a5ef3 into main Nov 14, 2023
6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Nov 14, 2023
@nfahlgren nfahlgren deleted the PYL-W0127 branch November 14, 2023 01:56
@nfahlgren nfahlgren added this to the PlantCV v4.1 milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality updates ready to review
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants