-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated color correction tutorial #1415
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add link to tutorial page
typo of trait variable name
add link to detect_color_card doc page
add file description
add spaces for readability and add missing measurements
HaleySchuhl
added
documentation
Documentation issues or features
update
Updates an existing feature/method
cleanup
Code quality updates
labels
Dec 1, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1415 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 158 158
Lines 6944 6944
=========================================
Hits 6944 6944
Flags with carried forward coverage won't be shown. Click here to find out more.
|
extra examples of grabbing outputs
nfahlgren
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cleanup
Code quality updates
documentation
Documentation issues or features
ready to review
update
Updates an existing feature/method
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I updated the color correction tutorial to use
pcv.transform.detect_color_card
rather than the oldfind_color_card
function. Also added links to relevant doc pages, and made any corrections to doc pages about Outputs traits. Updated this spreadsheet too with all the new function names & such. Worth checking that I didn't miss anything here also.Type of update
Is this a:
Associated issues
#1387
Additional context
Add any other context about the problem here.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md