Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated color correction tutorial #1415

Merged
merged 8 commits into from
Jan 8, 2024
Merged

Conversation

HaleySchuhl
Copy link
Contributor

Describe your changes
I updated the color correction tutorial to use pcv.transform.detect_color_card rather than the old find_color_card function. Also added links to relevant doc pages, and made any corrections to doc pages about Outputs traits. Updated this spreadsheet too with all the new function names & such. Worth checking that I didn't miss anything here also.

Type of update
Is this a:

  • Update to documentation

Associated issues
#1387

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

add link to tutorial page
typo of trait variable name
add link to detect_color_card doc page
add file description
add spaces for readability and add missing measurements
@HaleySchuhl HaleySchuhl self-assigned this Dec 1, 2023
@HaleySchuhl HaleySchuhl added documentation Documentation issues or features update Updates an existing feature/method cleanup Code quality updates labels Dec 1, 2023
@HaleySchuhl HaleySchuhl added this to Pull Requests in PlantCV4 via automation Dec 1, 2023
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.1 milestone Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c7b4ec) 100.00% compared to head (c476da5) 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1415   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          158       158           
  Lines         6944      6944           
=========================================
  Hits          6944      6944           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...cv/plantcv/photosynthesis/reassign_frame_labels.py 100.00% <ø> (ø)

extra examples of grabbing outputs
@nfahlgren nfahlgren merged commit 5bd2e14 into main Jan 8, 2024
6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Jan 8, 2024
@nfahlgren nfahlgren deleted the updated_color_correction_tutorial branch January 8, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality updates documentation Documentation issues or features ready to review update Updates an existing feature/method
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants