Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyPi deploy workflow to use OIDC authentication #1424

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Jan 16, 2024

Describe your changes
Updates the GitHub Action workflow that deploys PlantCV releases to PyPI to use the PyPA Action and OIDC authentication.

Type of update
Is this a: update to new security protocols for PyPI

Additional context
GitHub Action: https://github.com/marketplace/actions/pypi-publish

PyPI no longer supports username/password authentication:

Username/Password authentication is no longer supported. Migrate to API
         Tokens or Trusted Publishers instead. See                              
         https://pypi.org/help/#apitoken and                                    
         https://pypi.org/help/#trusted-publishers  

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added bugfix Bug fixes work in progress Mark work in progress labels Jan 16, 2024
@nfahlgren nfahlgren added this to the PlantCV v4.2 milestone Jan 16, 2024
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5bd2e14) 100.00% compared to head (dd1b73d) 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1424   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          158       158           
  Lines         6944      6944           
=========================================
  Hits          6944      6944           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@nfahlgren nfahlgren added ready to review and removed work in progress Mark work in progress labels Jan 16, 2024
@nfahlgren nfahlgren merged commit 72d85da into main Jan 16, 2024
6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Jan 16, 2024
@nfahlgren nfahlgren deleted the fix-pypi-deploy branch January 16, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants