Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc function improvements #433

Merged
merged 4 commits into from
Aug 22, 2019
Merged

Misc function improvements #433

merged 4 commits into from
Aug 22, 2019

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Aug 22, 2019 •
edited
Loading

Description

  • Make it optional for the first segment to be classified as stem regardless in the segment_sort function
  • Update method for sorting through segments in the segment_insertion_angle function, makes it quicker and more robust to measuring every leaf.
  • Update plotting method for segment_id since the previous method can give a weird artifact when plotting segments that have been combined.
  • Update pruning function
  • Removing old warnings that aren't really relevant anymore

Types of changes

  • Enhancements

Checklist:

  • Relevant tests (and test data) have been added or updated and passed.
  • The documentation was added or updated.
  • Relevant issues were updated or added.

@HaleySchuhl
misc function improvements
9dbe3f0 
- Make it optional for the first segment to be classified as stem regardless in the segment_sort function
- Update method for sorting through segments in the segment_insertion_angle function, makes it quicker and more robust to measuring every leaf.
- Update plotting method for segment_id since the previous method can give a weird artifact when plotting segments that have been combined.
- Update pruning function
- Removing old warnings that aren't really relevant anymore
-
@HaleySchuhl
update test
e6daae0
@HaleySchuhl HaleySchuhl added the enhancement Enhancements to existing features label Aug 22, 2019
@HaleySchuhl HaleySchuhl self-assigned this Aug 22, 2019
@HaleySchuhl HaleySchuhl added this to New Issues in PlantCV3 via automation Aug 22, 2019
@HaleySchuhl HaleySchuhl added the work in progress Mark work in progress label Aug 22, 2019
@HaleySchuhl HaleySchuhl removed the work in progress Mark work in progress label Aug 22, 2019
@coveralls
Copy link

coveralls commented Aug 22, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.0003%) to 99.857% when pulling e913026 on misc_function_improvements into 08774ff on master.

nfahlgren
nfahlgren approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@nfahlgren nfahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nfahlgren nfahlgren merged commit dc27ad6 into master Aug 22, 2019
PlantCV3 automation moved this from New Issues to Done Aug 22, 2019
@nfahlgren nfahlgren deleted the misc_function_improvements branch August 22, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfahlgren nfahlgren nfahlgren approved these changes

Assignees

@HaleySchuhl HaleySchuhl

Labels
enhancement Enhancements to existing features
Projects
No open projects
PlantCV3
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HaleySchuhl @coveralls @nfahlgren