Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watershed segmentation #767

Merged
merged 47 commits into from
May 4, 2022
Merged

Watershed segmentation #767

merged 47 commits into from
May 4, 2022

Conversation

JorgeGtz
Copy link
Contributor

@JorgeGtz JorgeGtz commented May 4, 2021

Describe your changes
Add segment_image_series function. It performs watershed segmentation using the spatial dimensions and time through the frames in the image series.

Type of update
Is this a:

  • New feature or feature enhancement

Associated issues
Associated discussion #668

Additional context
This function aims at solving the problem of segmenting overlapping plants in a multi-plant image series

@JorgeGtz JorgeGtz added new feature New feature ideas and solutions work in progress Mark work in progress labels May 4, 2021
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #767 (b0f4eea) into 4.x (d7fd94a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               4.x      #767   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          156       157    +1     
  Lines         6622      6681   +59     
=========================================
+ Hits          6622      6681   +59     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/__init__.py 100.00% <ø> (ø)
plantcv/plantcv/segment_image_series.py 100.00% <100.00%> (ø)
plantcv/__init__.py 100.00% <0.00%> (ø)

@JorgeGtz JorgeGtz closed this Aug 17, 2021
@JorgeGtz
Copy link
Contributor Author

Checks were not going

@JorgeGtz JorgeGtz reopened this Aug 17, 2021
@nfahlgren
Copy link
Member

I think checks won’t run while there are merge conflicts

@JorgeGtz JorgeGtz added ready to review and removed work in progress Mark work in progress labels Aug 31, 2021
@HaleySchuhl HaleySchuhl added this to Pull Requests in PlantCV4 via automation Sep 24, 2021
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.x milestone Sep 24, 2021
@HaleySchuhl HaleySchuhl requested review from HaleySchuhl and removed request for HaleySchuhl November 23, 2021 17:48
@nfahlgren nfahlgren changed the base branch from master to 4.x February 28, 2022 20:02
@nfahlgren
Copy link
Member

I think in debug mode all the frames are plotted, I think we need a different way to visualize this as it opens too many figures in Jupyter

minor edits, including removing the line that re-disables the debug mode after plotting.
streamline and import specific functions being used rather than the whole pcv package
@nfahlgren
Copy link
Member

Thanks @JorgeGtz and @HaleySchuhl!

@nfahlgren nfahlgren merged commit f96679b into 4.x May 4, 2022
PlantCV4 automation moved this from Pull Requests to Done May 4, 2022
@nfahlgren nfahlgren deleted the watershed-segmentation branch May 4, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature ideas and solutions ready to review
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants