-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update photosynthesis package to use xarray and analyze entire induction curve protocols #790
update photosynthesis package to use xarray and analyze entire induction curve protocols #790
Conversation
update the way INF file is located. make it more agnostic to binary image type
switch strategies, use INF file as input and find all image data that corresponds
comment out my code
start adding the code for creating xarray objects
update transpose to be appropriate for x-array now instead of numpy
now making x-arrays that have parameter labels embedded
overhaul the way data is formatted after being read in
replace with debug method
extract fmax for plotting
update docs and other code to make more consistent with pcv.readimage
other misc updates to comments
overhaul function to accept x-array data from read_cropreporter
first draft at writing new NPQ analysis function
update outputs names and observation data getting stored
update observations
correct source function in observations
mixed up .DAT and .INF
update logic
here's an issue from 2015(!) Don't squeeze DataArray before plotting |
Using gd = FacetGrid(data=fvfm, col="measurement", col_wrap=1)
gd.map_dataarray(xr.plot.imshow, "x", "y") We could put this directly in the YII and NPQ functions for now and not use the |
@nfahlgren next level wizardry! |
also, for hte col_wrap arg I suggest |
this will all fail if the should we just always limit to pcolormesh()? what does a line plot return from xarray?
|
Timepoint frame labels other than Fm/Fmp, F0, Fp, Fdark/Flight were None
@nfahlgren I think I may have broken the debug= functionality again. sometimes I see the plots even when I have debug=None or debug='print'. clearly I don't understand something. however, in terms of plotting data array data, I think it will be best to limit to facetgrid functionality using pcolormesh(). it greatly simplifies print_image and plot_image from what I can tell. |
I agree, limiting to pcolormesh makes sense for our usecase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I think everything is wrapped up! Thanks for the huge effort on this @dschneiderch and @HaleySchuhl!
This pull request implements the new data model for psII measurements and associated analyze_* functions.
We are using a new class to store multiple data arrays. Each data array has 4 dimensions (x, y, frame_label, measurement). Each data array must have a predefined name: darkadapted, lightadapted, rgb, chlorophyll, anthocyanin
[x] PSII_data class to store multiple xarray data arrays
[x] read_cropreporter to import data from cropreporter instrument
[] read_walz to import data from walz imaging pam
[x] analyze_yii to analyze photosynthetic efficiency for any number of measurements
[x] analyze_npq to analyze nonphotochemical quenching for any number of measurements
[x] tests
[x] documentation
Type of update
Is this a:
Associated issues
closes #636
Additional context
Add any other context about the problem here.