Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line endings #811

Merged
merged 2 commits into from
Aug 5, 2021
Merged

Fix line endings #811

merged 2 commits into from
Aug 5, 2021

Conversation

nfahlgren
Copy link
Member

Describe your changes
Updates gitattributes to exclude common binary files from end-of-line normalization. Normalizes line endings for existing files that were checked in with CRLF line endings and replaces them with LF line endings.

Type of update
Is this a: Bug fix

Additional context
https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings

@nfahlgren nfahlgren added the bugfix Bug fixes label Aug 5, 2021
@nfahlgren nfahlgren added this to the PlantCV v3.14.0 milestone Aug 5, 2021
@nfahlgren nfahlgren added this to In progress in PlantCV3 via automation Aug 5, 2021
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #811 (dafb409) into master (40497c5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #811   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          142       142           
  Lines         6479      6479           
=========================================
  Hits          6479      6479           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@nfahlgren
Copy link
Member Author

Thanks for bringing up this issue @JorgeGtz!

@nfahlgren nfahlgren merged commit f375982 into master Aug 5, 2021
PlantCV3 automation moved this from In progress to Done Aug 5, 2021
@nfahlgren nfahlgren deleted the fix-line-endings branch August 5, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fixes
Projects
No open projects
PlantCV3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants