Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format for my header #813

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Conversation

typelogic
Copy link
Contributor

@typelogic typelogic commented Aug 10, 2021

Describe your changes
Fix header format issue to read wavelength values containing a space before a newline in the opening { bracket. Also I needed to lowercase Wavelength string. Here is the spectral header file where it failed to parse.

Type of update

  • Bug fix

Additional context
I got this spectral datasets here

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #813 (c9a4e84) into master (f375982) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #813   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          142       142           
  Lines         6479      6482    +3     
=========================================
+ Hits          6479      6482    +3     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/hyperspectral/read_data.py 100.00% <100.00%> (ø)

Copy link
Member

@nfahlgren nfahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @typelogic!

@nfahlgren nfahlgren added this to In progress in PlantCV3 via automation Aug 12, 2021
@nfahlgren nfahlgren added this to the PlantCV v3.14.0 milestone Aug 12, 2021
@nfahlgren nfahlgren merged commit 260aa20 into danforthcenter:master Aug 12, 2021
PlantCV3 automation moved this from In progress to Done Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
PlantCV3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants