Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation sub-package and point annotation tool (a.k.a. interactive CustomROI) #816

Merged
merged 66 commits into from
Dec 14, 2021

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Aug 16, 2021

Describe your changes
Adds an interactive point collection tool that aims to streamline the process of defining a polygon ROI (pcv.roi.custom). This tool will belong within a new sub-package containing annotation tools. This point annotation was found to have other useful application and fit within the broader theme of interacting with images with the goal of collecting annotations of some type.

Type of update
Is this a:

  • New feature or feature enhancement

Associated issues
#815

Additional context
Add any other context about the problem here.

@HaleySchuhl HaleySchuhl added new feature New feature ideas and solutions work in progress Mark work in progress labels Aug 16, 2021
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.x milestone Aug 16, 2021
@HaleySchuhl HaleySchuhl self-assigned this Aug 16, 2021
@HaleySchuhl HaleySchuhl changed the base branch from master to 4.x August 16, 2021 15:15
@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #816 (4c6f937) into 4.x (d4fbd9a) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 4c6f937 differs from pull request most recent head 9136447. Consider uploading reports for the commit 9136447 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               4.x      #816   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          150       151    +1     
  Lines         6647      6695   +48     
=========================================
+ Hits          6647      6695   +48     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/__init__.py 100.00% <ø> (ø)
plantcv/plantcv/annotate/points.py 100.00% <100.00%> (ø)
plantcv/plantcv/classes.py 100.00% <100.00%> (ø)
plantcv/__init__.py 100.00% <0.00%> (ø)
plantcv/plantcv/roi/roi_methods.py 100.00% <0.00%> (ø)
plantcv/plantcv/hyperspectral/calibrate.py 100.00% <0.00%> (ø)

@HaleySchuhl HaleySchuhl added ready to review and removed work in progress Mark work in progress labels Nov 23, 2021
Copy link
Contributor

@JorgeGtz JorgeGtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @HaleySchuhl ! thank you

@HaleySchuhl HaleySchuhl merged commit a086228 into 4.x Dec 14, 2021
PlantCV4 automation moved this from Pull Requests to Done Dec 14, 2021
@HaleySchuhl HaleySchuhl deleted the interactive_roi branch December 14, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature ideas and solutions ready to review
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants