Update YII and NPQ measurements and options #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the user to round (if wanted) downstream
Use 100 bins for YII measurements
* Adds min/max bin control * Adds mode measurement * Updates histogram plot
This was
linked to
issues
Oct 13, 2021
Codecov Report
@@ Coverage Diff @@
## 4.x #826 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 150 150
Lines 6631 6657 +26
=========================================
+ Hits 6631 6657 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
annacasto
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Updates the
pcv.photosynthesis.analyze_yiiandpcv.photosynthesis.analyze_npqfunctions.binsoption fromanalyze_yiiand hardcodes the histogram to 100 bins because the YII ranges are fixed to 0–1 and 100 creates bins with a width of 0.01, which we felt was sufficient. It also ensures that the bin labels, which are recorded as observation labels are unique.binsoption fromanalyze_npqand hardcodes the histogram to 100 bins. NPQ does not have a normalized range, so bin width will vary with the range but 100 bins are typically sufficient for a smooth plot.min_binandmax_binoptions toanalyze_npqto control the histogram range.min_bindefaults to zero andmax_binto auto (the maximum observed value), but both can be set or set to auto.Type of update
Is this a: New feature or feature enhancement
Associated issues
Closes #814 and #818