Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency OpenCV to v4 #846

Merged
merged 5 commits into from
Dec 13, 2021
Merged

Update dependency OpenCV to v4 #846

merged 5 commits into from
Dec 13, 2021

Conversation

nfahlgren
Copy link
Member

Describe your changes
OpenCV v3 builds in conda-forge no longer have newer versions of Python, which is starting to cause issues building the plantcv-feedstock. This PR releases v3 pins on OpenCV to allow for builds with OpenCV4. It also shifts CI tests from Python v3.6-3.8 to v3.7-3.9.

Type of update
Is this a: Update to dependencies

Associated issues
Closes #667

@nfahlgren nfahlgren added the enhancement Enhancements to existing features label Dec 10, 2021
@nfahlgren nfahlgren added this to the PlantCV v3.14.0 milestone Dec 10, 2021
@nfahlgren nfahlgren added this to In progress in PlantCV3 via automation Dec 10, 2021
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #846 (4a3fd7b) into master (d06922d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #846   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          142       142           
  Lines         6207      6207           
=========================================
  Hits          6207      6207           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/roi/roi_methods.py 100.00% <100.00%> (ø)

@nfahlgren nfahlgren merged commit aec9924 into master Dec 13, 2021
PlantCV3 automation moved this from In progress to Done Dec 13, 2021
@nfahlgren nfahlgren deleted the update-opencv4 branch December 13, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements to existing features
Projects
No open projects
PlantCV3
  
Done
Development

Successfully merging this pull request may close these issues.

Please support the newest version of opencv
2 participants