Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize tests into separate modules #850

Merged
merged 192 commits into from
Jan 25, 2022
Merged

Reorganize tests into separate modules #850

merged 192 commits into from
Jan 25, 2022

Conversation

nfahlgren
Copy link
Member

Describe your changes
Reorganizes tests into individual modules instead of one large tests file. Streamlines/reorganizes test data to remove unnecessary/redundant test data in favor of smaller/faster test samples. Updates tests to use parameters and test a single function per test.

Type of update
Is this a: New feature or feature enhancement

@nfahlgren nfahlgren added ready to review and removed work in progress Mark work in progress labels Jan 21, 2022
@nfahlgren
Copy link
Member Author

@HaleySchuhl @JorgeGtz this PR now re-implements our tests with 100% coverage but split into smaller modules, feel free to take a look when you have time. There are a lot of files changed but most of those changes are:

  • Addition of new test module files
  • Moving data from the original tests data directories to the unified testdata directory
  • Removal of test data that is no longer used/needed

There are a few minor updates to some PlantCV functions that should just refactor the code to remove the need for a few tests (e.g. removed all cases of if params.debug is not None).

So other than these few latter cases, most of the other file changes don't need to be reviewed thoroughly since they are just cleaned up tests moved from tests.py into modules.

One last thing, the empty file tests.py is still included because I think that will help with conflict resolution as we merge these changes into existing PRs. We can remove it later after we've dealt with those conflicts.

@nfahlgren nfahlgren merged commit 29f03da into master Jan 25, 2022
PlantCV3 automation moved this from In progress to Done Jan 25, 2022
@nfahlgren nfahlgren deleted the reorg-tests branch January 25, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review testing Features related to testing and deployment
Projects
No open projects
PlantCV3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants