Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyperspectral rotation #888

Merged
merged 24 commits into from
Jun 8, 2022
Merged

Hyperspectral rotation #888

merged 24 commits into from
Jun 8, 2022

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented May 10, 2022 •
edited

Describe your changes
Add new function, based on np.rot90, that is formatted for HSI instances.

Type of update

  • New feature or feature enhancement

Associated issues

Additional context

@HaleySchuhl HaleySchuhl added the new feature New feature ideas and solutions label May 10, 2022
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.x milestone May 10, 2022
@HaleySchuhl HaleySchuhl self-assigned this May 10, 2022
@HaleySchuhl HaleySchuhl added this to Pull Requests in PlantCV4 via automation May 10, 2022
@HaleySchuhl HaleySchuhl added the work in progress Mark work in progress label May 10, 2022
@HaleySchuhl
Update test_rot90.py
2018f85 
change the way hsi data is called? error said cannor call module
@HaleySchuhl
It says module object is not callable, because your code is calling a…
05ba0d8 
… module object
@HaleySchuhl
Update __init__.py
605f2d2
@codecov
Copy link

codecov bot commented May 10, 2022 •
edited

Codecov Report

Merging #888 (924a65f) into 4.x (5c030a6) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 924a65f differs from pull request most recent head 8d89cf6. Consider uploading reports for the commit 8d89cf6 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##               4.x      #888   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          157       158    +1     
  Lines         6690      6701   +11     
=========================================
+ Hits          6690      6701   +11
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/hyperspectral/__init__.py 100.00% <100.00%> (ø)
plantcv/plantcv/hyperspectral/rot90.py 100.00% <100.00%> (ø)
plantcv/plantcv/transform/color_correction.py 100.00% <100.00%> (ø)
plantcv/plantcv/hyperspectral/read_data.py 100.00% <0.00%> (ø)

@HaleySchuhl HaleySchuhl added ready to review and removed work in progress Mark work in progress labels May 10, 2022
@HaleySchuhl HaleySchuhl requested a review from JorgeGtz May 10, 2022 16:09
@nfahlgren
Copy link
Member

Be sure to take a look at the DeepSource report, since this PR is based on the main branch the issues it identifies are specific to the PR (unlike those based on 4.x).

@HaleySchuhl HaleySchuhl added work in progress Mark work in progress and removed ready to review labels May 11, 2022
@HaleySchuhl HaleySchuhl added ready to review and removed work in progress Mark work in progress labels May 23, 2022
@HaleySchuhl HaleySchuhl changed the base branch from master to 4.x May 23, 2022 16:15
@jdavidpeery jdavidpeery mentioned this pull request Jun 1, 2022
Open
@jdavidpeery
Copy link
Contributor

Since you're adding a new doc page, does it need to be referenced in the mkdocs.yml file?

@HaleySchuhl
Copy link
Contributor Author

Since you're adding a new doc page, does it need to be referenced in the mkdocs.yml file?

Ohhh you're right!

@HaleySchuhl HaleySchuhl requested review from nfahlgren and removed request for JorgeGtz June 8, 2022 14:56
jdavidpeery
jdavidpeery approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@jdavidpeery jdavidpeery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Already added and resolved all my comments

@nfahlgren
Copy link
Member

Are the changes to the color correction module due to the 4.x branch being out of date? If so let's update 4.x before merging this PR

@HaleySchuhl HaleySchuhl merged commit 895fe10 into 4.x Jun 8, 2022
PlantCV4 automation moved this from Pull Requests to Done Jun 8, 2022
@HaleySchuhl HaleySchuhl deleted the hyperspectral_rotation branch June 8, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdavidpeery jdavidpeery jdavidpeery approved these changes

@nfahlgren nfahlgren Awaiting requested review from nfahlgren

Assignees

@HaleySchuhl HaleySchuhl

Labels
new feature New feature ideas and solutions ready to review
Projects
PlantCV4
  
Done
Milestone
PlantCV v4.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HaleySchuhl @nfahlgren @jdavidpeery