Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overindented docstrings #901

Merged
merged 4 commits into from
Jun 10, 2022
Merged

Conversation

nfahlgren
Copy link
Member

Describe your changes
deepsource.io identified several docstrings that were overindented.

Type of update
Is this a: minor code quality improvement

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added ready to review cleanup Code quality updates labels Jun 10, 2022
@nfahlgren nfahlgren added this to the PlantCV v3.14.1 milestone Jun 10, 2022
@nfahlgren nfahlgren added this to In progress in PlantCV3 via automation Jun 10, 2022
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #901 (20a0773) into master (6021db7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #901   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          141       141           
  Lines         6006      6006           
=========================================
  Hits          6006      6006           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/crop.py 100.00% <ø> (ø)
plantcv/plantcv/hyperspectral/_avg_reflectance.py 100.00% <ø> (ø)
...antcv/plantcv/hyperspectral/_inverse_covariance.py 100.00% <ø> (ø)
...lantcv/plantcv/hyperspectral/extract_wavelength.py 100.00% <ø> (ø)
plantcv/plantcv/morphology/_iterative_prune.py 100.00% <ø> (ø)
plantcv/plantcv/morphology/analyze_stem.py 100.00% <ø> (ø)
plantcv/plantcv/morphology/find_branch_pts.py 100.00% <ø> (ø)
plantcv/plantcv/morphology/find_tips.py 100.00% <ø> (ø)
plantcv/plantcv/morphology/prune.py 100.00% <ø> (ø)
plantcv/plantcv/morphology/segment_angle.py 100.00% <ø> (ø)
... and 16 more

@nfahlgren nfahlgren merged commit 98b7c7d into master Jun 10, 2022
PlantCV3 automation moved this from In progress to Done Jun 10, 2022
@nfahlgren nfahlgren deleted the deepsource-overindented-docstrings branch June 10, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality updates ready to review
Projects
No open projects
PlantCV3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants