Hsi filename pattern matching #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #916 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 141 141
Lines 6000 6011 +11
=========================================
+ Hits 6000 6011 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
remove white space, split on "=" or ":" and remove whitespace from keys to match new strings
HaleySchuhl
added
ready to review
and removed
work in progress
Two line returns between functions and one blank line at the end of a file
nfahlgren
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
Look great @HaleySchuhl! I tested trying to "break" the hdr file and the only thing that did it was using tabs instead of spaces. But I don't think we need to worry about that possibility now, until we see some data like that (if ever).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Updates the
pcv.hyperspectral.read_data.pyfile to introduce a new method to handle pattern matching between data and header filenames.Type of update
Is this a:
Associated issues
Issue #915
Additional context
Add any other context about the problem here.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md