Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sample_images to handle phenodata datasets #925

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Jul 25, 2022

Describe your changes
plantcv.utils.sample_images (used by plantcv-utils.py sample_images) was not updated to handle phenodata datasets (see #923). This PR refactors sample_images to modularize the code and adds a sampling method for phenodata datasets.

Type of update
Is this a: Bug fix

Associated issues
Closes #923

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

Note: test images are empty files, real images are not needed for testing sampling
@nfahlgren nfahlgren added the bugfix Bug fixes label Jul 25, 2022
@nfahlgren nfahlgren added this to the PlantCV v4.x milestone Jul 25, 2022
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Jul 25, 2022
@nfahlgren nfahlgren linked an issue Jul 25, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #925 (3decc4b) into 4.x (4e1bf48) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               4.x      #925   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          160       160           
  Lines         6799      6826   +27     
=========================================
+ Hits          6799      6826   +27     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/utils/sample_images.py 100.00% <100.00%> (ø)

@nfahlgren nfahlgren merged commit d49fb20 into 4.x Jul 26, 2022
PlantCV4 automation moved this from Pull Requests to Done Jul 26, 2022
@nfahlgren nfahlgren deleted the add-dataset-type-to-sample-images branch July 26, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fixes
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

sample_images filtering
2 participants