Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gif to gitattributes to treat as binary #935

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Aug 18, 2022

Describe your changes
To avoid conversion of line endings between Windows, macOS, and Linux systems when cloning the git repository, we specify in .gitattributes that some file types should be treated as binary and remain unmodified. This PR adds .gif file types to that list.

Type of update
Is this a: Bug fix

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added the bugfix Bug fixes label Aug 18, 2022
@nfahlgren nfahlgren added this to the PlantCV v3.14.1 milestone Aug 18, 2022
@nfahlgren nfahlgren added this to In progress in PlantCV3 via automation Aug 18, 2022
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #935 (58ce00f) into master (013e5a5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #935   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          141       141           
  Lines         6011      6011           
=========================================
  Hits          6011      6011           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@nfahlgren nfahlgren merged commit d1456d0 into master Aug 19, 2022
PlantCV3 automation moved this from In progress to Done Aug 19, 2022
@nfahlgren nfahlgren deleted the add-gif-binary-gitattributes branch August 19, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
PlantCV3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants