Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 4.0 #944

Merged
merged 42 commits into from
Sep 6, 2022
Merged

Update 4.0 #944

merged 42 commits into from
Sep 6, 2022

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Sep 6, 2022

Describe your changes
Merges updates from main and 4.x into the release-4.0 branch.

Type of update
Is this a: Update

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #944 (4390066) into release-4.0 (696704c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0      #944   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              160       161    +1     
  Lines             6827      6840   +13     
=============================================
+ Hits              6827      6840   +13     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/_helpers.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze_bound_horizontal.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze_bound_vertical.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze_object.py 100.00% <100.00%> (ø)
plantcv/plantcv/crop_position_mask.py 100.00% <100.00%> (ø)
plantcv/plantcv/find_objects.py 100.00% <100.00%> (ø)
plantcv/plantcv/morphology/_iterative_prune.py 100.00% <100.00%> (ø)
plantcv/plantcv/morphology/check_cycles.py 100.00% <100.00%> (ø)
plantcv/plantcv/morphology/find_branch_pts.py 100.00% <100.00%> (ø)
plantcv/plantcv/morphology/find_tips.py 100.00% <100.00%> (ø)
... and 11 more

@HaleySchuhl HaleySchuhl added the update Updates an existing feature/method label Sep 6, 2022
@HaleySchuhl HaleySchuhl added this to Pull Requests in PlantCV4 via automation Sep 6, 2022
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.0 milestone Sep 6, 2022
@nfahlgren nfahlgren merged commit 4a514f7 into release-4.0 Sep 6, 2022
PlantCV4 automation moved this from Pull Requests to Done Sep 6, 2022
@nfahlgren nfahlgren deleted the update-4.0 branch September 6, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update Updates an existing feature/method
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants